Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this PR is not to be merged directly, but rather show what kind of changes would be necessary to port this development to Coq 8.7.
Of course, this is in response to #1 from @herbelin.
Overall it went rather smoothly, the most unsatisfactory point for me would be the files such as InstSyn.v: you are defining a submodule, which needs to provide some definitions, and you want some of them to be constructors.
What you did is define the constructors with some alternative name
Const', and then map the good name withDefinition Const := Const'.. This is fine, except that in Coq > 8.4, you cannot use such definitions in a pattern.Is there a nice solution for this?
Anyway, I also do not pretend that these changes are minimalistic or even good, don't hesitate to suggest anything!